delamarch3 commented on PR #6675:
URL: https://github.com/apache/arrow-rs/pull/6675#issuecomment-2457911313
Thanks @tustvold. I ran some benchmarks on this and it turns out it is quite
a bit slower. I've changed it slightly so it just subtracts the difference
which seems to have brought it back closer to where it was, I can open a new
PR? Here's the benchmark results:
This PR:
```text
run_ends_len = 64 time: [3.9878 µs 4.0035 µs 4.0204 µs]
change: [-1.3684% -0.4485% +0.5210%] (p = 0.34 >
0.05)
No change in performance detected.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe
run_ends_len = 512 time: [56.654 µs 57.076 µs 57.458 µs]
change: [-1.7583% -1.0124% -0.2300%] (p = 0.01 <
0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
run_ends_len = 1024 time: [151.37 µs 151.83 µs 152.34 µs]
change: [-4.5739% -3.1197% -1.6545%] (p = 0.00 <
0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
1 (1.00%) low mild
4 (4.00%) high mild
6 (6.00%) high severe
```
My updates:
```text
run_ends_len = 64 time: [2.7373 µs 2.8041 µs 2.8841 µs]
change: [-32.545% -31.650% -30.574%] (p = 0.00 <
0.05)
Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
6 (6.00%) high mild
8 (8.00%) high severe
run_ends_len = 512 time: [4.5291 µs 4.5413 µs 4.5548 µs]
change: [-91.973% -91.902% -91.821%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
2 (2.00%) high mild
5 (5.00%) high severe
run_ends_len = 1024 time: [6.3687 µs 6.4206 µs 6.4869 µs]
change: [-95.802% -95.750% -95.693%] (p = 0.00 <
0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
4 (4.00%) high mild
6 (6.00%) high severe
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
