delamarch3 opened a new pull request, #6691: URL: https://github.com/apache/arrow-rs/pull/6691
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Related to https://github.com/apache/arrow-rs/pull/6675 # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> After running some benchmarks it turned out that the changes introduced in my previous PR were quite slow. This should bring it back closer to how it was before. ```text run_ends_len = 64 time: [3.9878 µs 4.0035 µs 4.0204 µs] change: [-1.3684% -0.4485% +0.5210%] (p = 0.34 > 0.05) No change in performance detected. Found 6 outliers among 100 measurements (6.00%) 2 (2.00%) high mild 4 (4.00%) high severe run_ends_len = 512 time: [56.654 µs 57.076 µs 57.458 µs] change: [-1.7583% -1.0124% -0.2300%] (p = 0.01 < 0.05) Change within noise threshold. Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high mild run_ends_len = 1024 time: [151.37 µs 151.83 µs 152.34 µs] change: [-4.5739% -3.1197% -1.6545%] (p = 0.00 < 0.05) Performance has improved. Found 11 outliers among 100 measurements (11.00%) 1 (1.00%) low mild 4 (4.00%) high mild 6 (6.00%) high severe ``` ```text run_ends_len = 64 time: [2.7373 µs 2.8041 µs 2.8841 µs] change: [-32.545% -31.650% -30.574%] (p = 0.00 < 0.05) Performance has improved. Found 14 outliers among 100 measurements (14.00%) 6 (6.00%) high mild 8 (8.00%) high severe run_ends_len = 512 time: [4.5291 µs 4.5413 µs 4.5548 µs] change: [-91.973% -91.902% -91.821%] (p = 0.00 < 0.05) Performance has improved. Found 7 outliers among 100 measurements (7.00%) 2 (2.00%) high mild 5 (5.00%) high severe run_ends_len = 1024 time: [6.3687 µs 6.4206 µs 6.4869 µs] change: [-95.802% -95.750% -95.693%] (p = 0.00 < 0.05) Performance has improved. Found 10 outliers among 100 measurements (10.00%) 4 (4.00%) high mild 6 (6.00%) high severe ``` # What changes are included in this PR? I subtract the difference from `end` to keep it in bounds. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are there any user-facing changes? No <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please add the `breaking change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
