devanbenz commented on issue #6692:
URL: https://github.com/apache/arrow-rs/issues/6692#issuecomment-2462195083

   > > > Not sure about other type but for StringView, I can only think of 
iterating all the filtered row and `append_value` one by one. If there is no 
further optimization we can do, I think we can implement the append logic in 
datafusion
   > > 
   > > 
   > > 'append_value' does a copy though. Wouldn't that effectively still be a 
large amount of copies?
   > 
   > With this approach, we reduce the copying to a single step. Compared to 
the current approach, where copying happens in multiple stages (filtering, 
garbage collection, and coalescing), my proposal combines these steps into one. 
While benchmarks are needed to confirm any performance gains, this method 
should, at the very least, not perform worse than the existing one
   
   That makes sense. This would be a change downstream within Datafusion then 
correct? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to