amoeba commented on PR #44675: URL: https://github.com/apache/arrow/pull/44675#issuecomment-2463170196
A note about the patch here: I saw there were a number of ways to fix the issue, including just coercing everything to a vector. However, I thought it was cleaner to just directly use our internal `expect_equal` helper. See: ```r expect_true(all(concat_int == arrow_array(1:5))) # can be fixed by wrapping it in as.vector expect_true(as.vector(all(concat_int == arrow_array(1:5)))) # but this seems much cleaner to me expect_equal(concat_int, arrow_array(1:5)) <-- this is what I went with ``` Can reviewers please check my assumption that `expect_equal` is doing what we want here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
