findepi commented on code in PR #6703:
URL: https://github.com/apache/arrow-rs/pull/6703#discussion_r1834479112


##########
arrow-string/src/predicate.rs:
##########
@@ -350,7 +346,7 @@ mod tests {
     #[test]
     fn test_replace_like_wildcards_with_multiple_escape_chars() {
         let a_eq = "\\\\%";
-        let expected = "^\\\\%$";

Review Comment:
   after Rust parsing, this is `\\%` input. which should match any string 
starting with `\`
   so the regex should be `^\\` which looks like `"r\\\\"` in Rust source code.
   I.e. the value expected here wasn't quite correct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to