alamb commented on code in PR #6624: URL: https://github.com/apache/arrow-rs/pull/6624#discussion_r1834695119
########## parquet/src/arrow/arrow_reader/boolean_selection.rs: ########## @@ -0,0 +1,314 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::ops::Range; + +use arrow_array::{Array, BooleanArray}; +use arrow_buffer::{BooleanBuffer, BooleanBufferBuilder, MutableBuffer}; +use arrow_data::bit_iterator::BitIndexIterator; + +use super::{RowSelection, RowSelector}; + +/// A selection of rows, similar to [`RowSelection`], but based on a boolean array +#[derive(Debug, Clone, PartialEq, Eq)] +pub struct BooleanRowSelection { + selector: BooleanBuffer, Review Comment: One question I have while reviewing this PR is "why not just use `BooleanArray` directly?" It seems like most of these methods would be generally useful on `BooleanArray` (or perhaps as kernels) -- and in fact most of them are already (like union is `|` and intersection is `&`). Another thing that might be interesting to do if we really care about performance is to look into implementing in-place updates -- maybe something like https://docs.rs/arrow/latest/arrow/compute/fn.binary_mut.html for BooleanArray) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
