itsjunetime commented on code in PR #6690:
URL: https://github.com/apache/arrow-rs/pull/6690#discussion_r1835086786
##########
arrow-flight/src/encode.rs:
##########
@@ -700,6 +682,9 @@ mod tests {
use super::*;
#[test]
+ // flight_data_from_arrow_batch is deprecated but does exactly what we
need. Would probably be
Review Comment:
I guess I just didn't see the purpose for duplicating code when this method
already existed and did the exact same thing as `make_flight_data`. It also
seems that `flight_data_from_arrow_batch` is a perfectly fine method, just easy
to misuse, and that's why it was deprecated. Its behavior was duplicated in
many different places throughout this crate, though - I don't think it's
something that we would ever want to completely remove from usage, as it
clearly has an internal purpose.
When we want to remove `flight_data_from_arrow_batch` from the public API,
we could just comfortably make it private, and keep using its functionality
internally.
Does that make sense? I feel like I may not be explaining my thoughts
perfectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
