nealrichardson commented on a change in pull request #9717:
URL: https://github.com/apache/arrow/pull/9717#discussion_r594742955
##########
File path: r/R/dplyr.R
##########
@@ -347,13 +354,15 @@ arrow_mask <- function(.data) {
}
set_filters <- function(.data, expressions) {
- # expressions is a list of Expressions. AND them together and set them on
.data
- new_filter <- Reduce("&", expressions)
- if (isTRUE(.data$filtered_rows)) {
- # TRUE is default (i.e. no filter yet), so we don't need to & with it
- .data$filtered_rows <- new_filter
- } else {
- .data$filtered_rows <- .data$filtered_rows & new_filter
+ if (length(expressions)) {
Review comment:
FYI @ianmcook this is the fix for ARROW-11785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
