Dandandan commented on PR #6691: URL: https://github.com/apache/arrow-rs/pull/6691#issuecomment-2466802092
For me looks good - I feel somehow there probably should be more performance on the table. I believe the reason is `BitIterator` is currently doing the same as `filter_values.value_unchecked` so for using the iterator it is only the extra cost of the bounds check. I think it should be possible to improve `BitIterator` (use bitshift rather than using the current index) and use `unwrap_unchecked()` to be slightly more performant than the current solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
