findepi opened a new pull request, #6721:
URL: https://github.com/apache/arrow-rs/pull/6721
# Description
Improve default implementation of Array::is_nullable
Since is_nullable returns `false` if the array is guaranteed to not contain
any logical nulls, the correct default implementation could leverage
`self.logical_null_count` more appropriately than `self.null_count`.
To reduce chance of negative surprises in downstream projects, we could
introduce the new behavior under `is_logically_nullable` name and deprecate
`is_nullable` without changing it.
# Which issue does this PR close?
None
# Rationale for this change
Fix technically incorrect default implementation of `Array::is_nullable`
# What changes are included in this PR?
Change default implementation of `Array::is_nullable`.
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
