WillAyd commented on code in PR #677:
URL: https://github.com/apache/arrow-nanoarrow/pull/677#discussion_r1838751078
##########
src/nanoarrow/common/array_test.cc:
##########
@@ -1719,7 +1812,8 @@ TEST(ArrayTest, ArrayTestAppendToRunEndEncodedArray) {
EXPECT_EQ(ArrowArrayFinishBuilding(&array, NANOARROW_VALIDATION_LEVEL_FULL,
&error),
NANOARROW_OK);
-#if !defined(ARROW_VERSION_MAJOR) || ARROW_VERSION_MAJOR < 12
+#if !defined(NANOARROW_BUILD_TESTS_WITH_ARROW) ||
!defined(ARROW_VERSION_MAJOR) || \
Review Comment:
Do we want to add this here or leave as is?
##########
CMakeLists.txt:
##########
@@ -517,6 +520,27 @@ if(NANOARROW_BUILD_TESTS)
gmock_main
nanoarrow_coverage_config)
+ list(APPEND
Review Comment:
Just kept the loop scoped to adding the define for now, although there is
(as you've already mentioned) potential to use this for other parts of the
config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
