lidavidm commented on code in PR #2327:
URL: https://github.com/apache/arrow-adbc/pull/2327#discussion_r1842347048
##########
c/driver/framework/base_driver.h:
##########
@@ -116,8 +116,9 @@ class Option {
"': trailing data", value);
}
return parsed;
+ } else {
+ return status::InvalidArgument("Invalid integer value ",
this->Format());
}
- return status::InvalidArgument("Invalid integer value ",
this->Format());
Review Comment:
yeah, MSVC seems extremely pedantic about this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
