alamb commented on code in PR #6712:
URL: https://github.com/apache/arrow-rs/pull/6712#discussion_r1844480841
##########
arrow-select/src/filter.rs:
##########
@@ -431,17 +431,17 @@ where
R::Native: AddAssign,
{
let run_ends: &RunEndBuffer<R::Native> = array.run_ends();
- let mut values_filter = BooleanBufferBuilder::new(run_ends.len());
let mut new_run_ends = vec![R::default_value(); run_ends.len()];
let mut start = 0u64;
- let mut i = 0;
+ let mut j = 0;
let mut count = R::default_value();
let filter_values = predicate.filter.values();
+ let run_ends = run_ends.inner();
- for mut end in run_ends.inner().into_iter().map(|i| (*i).into() as u64) {
+ let pred: BooleanArray = BooleanBuffer::collect_bool(run_ends.len(), |i| {
Review Comment:
The improvement is due to using `BooleanBuffer::collect_bool` rather than a
builder. That makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
