alamb commented on code in PR #6711:
URL: https://github.com/apache/arrow-rs/pull/6711#discussion_r1844546855
##########
arrow-ipc/src/reader.rs:
##########
@@ -1702,6 +1702,41 @@ mod tests {
assert_eq!(batch, roundtrip_ipc(&batch));
}
+ #[test]
+ fn test_roundtrip_nested_dict_no_preserve_dict_id() {
Review Comment:
I verified that this test covers the bugfix by reverting the code changes
and running the tests:
```
called `Result::unwrap()` on an `Err` value:
InvalidArgumentError("dictionary id 0 not found in schema")
thread 'reader::tests::test_roundtrip_nested_dict_no_preserve_dict_id'
panicked at arrow-ipc/src/reader.rs:1735:79:
called `Result::unwrap()` on an `Err` value:
InvalidArgumentError("dictionary id 0 not found in schema")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
