ianmcook commented on a change in pull request #9716:
URL: https://github.com/apache/arrow/pull/9716#discussion_r595460633
##########
File path: r/R/dplyr.R
##########
@@ -424,11 +427,16 @@ restore_dplyr_features <- function(df, query) {
if (grouped) {
Review comment:
I checked that, and no, it turns out that `dplyr::group_by(.drop =
FALSE)` (with no dots arguments) does the same thing as `dplyr::ungroup()`. It
does not preserve `.drop`. One of the tests I added checks that we're
consistent with dplyr on that:
https://github.com/apache/arrow/pull/9716/files#diff-b54a9d9f7fc3cb71878c6396ac9b36893e7f60fb9f48c27fe41aeb5b8a1f5a48R237-R242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
