mapleFU commented on code in PR #44787:
URL: https://github.com/apache/arrow/pull/44787#discussion_r1848319080


##########
cpp/src/parquet/file_writer.cc:
##########
@@ -539,6 +540,7 @@ void WriteFileMetaData(const FileMetaData& file_metadata, 
ArrowOutputStream* sin
   metadata_len = static_cast<uint32_t>(position) - metadata_len;
 
   // Write Footer
+  metadata_len = ::arrow::bit_util::ToLittleEndian(metadata_len);
   PARQUET_THROW_NOT_OK(sink->Write(reinterpret_cast<uint8_t*>(&metadata_len), 
4));

Review Comment:
   ```suggestion
   {
     uint32_t metadata_len_le = ::arrow::bit_util::ToLittleEndian(metadata_len);
     
PARQUET_THROW_NOT_OK(sink->Write(reinterpret_cast<uint8_t*>(&metadata_len_le), 
4));
   }
   ```
   
   Can we solve like this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to