jayzhan211 commented on code in PR #6748:
URL: https://github.com/apache/arrow-rs/pull/6748#discussion_r1849377607
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -158,7 +158,7 @@ pub trait AsyncFileReader: Send {
fn get_metadata(&mut self) -> BoxFuture<'_, Result<Arc<ParquetMetaData>>>;
}
-impl AsyncFileReader for Box<dyn AsyncFileReader> {
+impl<'reader> AsyncFileReader for Box<dyn AsyncFileReader + 'reader> {
Review Comment:
Let's add comment to them. If I understand correctly, we want to return
Boxed Reader that **has references shorten than static** is the reason why we
need to implement Boxed Reader with shorter lifetime than static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
