kou commented on code in PR #44536:
URL: https://github.com/apache/arrow/pull/44536#discussion_r1849442339
##########
d/dub.json:
##########
@@ -0,0 +1,50 @@
+{
+ "name": "arrow-d",
+ "description": "Apache Arrow - D bindings",
+ "license": "Apache-2.0",
+ "toolchainRequirements": {
+ "frontend": ">=2.105.3"
+ },
+ "buildTypes": {
+ "debug": {
+ "buildOptions": [
+ "debugMode",
+ "debugInfo"
+ ]
+ },
+ "release": {
+ "buildOptions": [
+ "releaseMode",
+ "inline",
+ "optimize"
+ ]
+ }
+ },
+ "preBuildCommands": [
+ "\"$DUB\" run girtod -- -i source -o source
--use-runtime-linker"
Review Comment:
Can we use out-of-source build?
##########
.github/workflows/d.yml:
##########
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: D
+
+on:
+ push:
+ branches:
+ - '**'
+ - '!dependabot/**'
+ tags:
+ - '**'
+ paths:
+ - '.dockerignore'
+ - '.github/workflows/d.yml'
+ - 'ci/docker/*d*'
+ - 'ci/scripts/c_glib_*'
+ - 'ci/scripts/cpp_*'
+ - 'ci/scripts/d_*'
+ - 'c_glib/**'
+ - 'cpp/**'
+ - 'docker-compose.yml'
+ - 'd/**'
+ pull_request:
+ paths:
+ - '.dockerignore'
+ - '.github/workflows/d.yml'
+ - 'ci/docker/*d*'
+ - 'ci/scripts/c_glib_*'
+ - 'ci/scripts/cpp_*'
+ - 'ci/scripts/d_*'
+ - 'c_glib/**'
+ - 'cpp/**'
+ - 'docker-compose.yml'
+ - 'd/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ ARCHERY_DEBUG: 1
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+ docker:
+ name: AMD64 Ubuntu ${{ matrix.ubuntu }} Glib & D
Review Comment:
```suggestion
name: AMD64 Ubuntu ${{ matrix.ubuntu }} GLib & D
```
##########
d/dub.json:
##########
Review Comment:
We can't add license header to this file because this is JSON, right?
Could you add this file to
https://github.com/apache/arrow/blob/main/dev/release/rat_exclude_files.txt ?
##########
ci/docker/ubuntu-d.dockerfile:
##########
Review Comment:
Could you rename this to `linux-apt-d.dockerfile` and use `ubuntu-c-glib` as
the base image like `ubuntu-ruby` does?
https://github.com/apache/arrow/blob/33e8cbb2eae70efb5ec4efc07e8fd79edb1057cf/docker-compose.yml#L853-L875
##########
.github/workflows/d.yml:
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: D
+
+on:
+ push:
+ branches:
+ - '**'
+ - '!dependabot/**'
+ tags:
+ - '**'
+ paths:
+ - '.dockerignore'
+ - '.github/workflows/d.yml'
+ - 'ci/docker/*d*'
Review Comment:
```suggestion
- 'ci/docker/*-d.dockerfile'
```
> One question: is docker_ruby already included in c_glib?
What is referred by the `docker_ruby`?
https://github.com/apache/arrow/blob/main/ci/docker/linux-apt-ruby.dockerfile ?
##########
.github/workflows/d.yml:
##########
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: D
+
+on:
+ push:
+ branches:
+ - '**'
+ - '!dependabot/**'
+ tags:
+ - '**'
+ paths:
+ - '.dockerignore'
+ - '.github/workflows/d.yml'
+ - 'ci/docker/*d*'
+ - 'ci/scripts/c_glib_*'
+ - 'ci/scripts/cpp_*'
+ - 'ci/scripts/d_*'
+ - 'c_glib/**'
+ - 'cpp/**'
+ - 'docker-compose.yml'
+ - 'd/**'
+ pull_request:
+ paths:
+ - '.dockerignore'
+ - '.github/workflows/d.yml'
+ - 'ci/docker/*d*'
+ - 'ci/scripts/c_glib_*'
+ - 'ci/scripts/cpp_*'
+ - 'ci/scripts/d_*'
+ - 'c_glib/**'
+ - 'cpp/**'
+ - 'docker-compose.yml'
+ - 'd/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ ARCHERY_DEBUG: 1
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+ docker:
+ name: AMD64 Ubuntu ${{ matrix.ubuntu }} Glib & D
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ ubuntu:
+ - 22.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac #
v4.0.0
Review Comment:
```suggestion
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 #
v4.2.1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
