mapleFU commented on issue #44690:
URL: https://github.com/apache/arrow/issues/44690#issuecomment-2488361829
```diff
diff --git a/cpp/src/arrow/array/builder_primitive.h
b/cpp/src/arrow/array/builder_primitive.h
index de7af1b46b..be9761fb46 100644
--- a/cpp/src/arrow/array/builder_primitive.h
+++ b/cpp/src/arrow/array/builder_primitive.h
@@ -211,6 +211,9 @@ class NumericBuilder
/// \return Status
Status AppendValues(const std::vector<value_type>& values,
const std::vector<bool>& is_valid) {
+ if (values.empty()) {
+ return Status::OK();
+ }
return AppendValues(values.data(), static_cast<int64_t>(values.size()),
is_valid);
}
@@ -218,6 +221,9 @@ class NumericBuilder
/// \param[in] values a std::vector of values
/// \return Status
Status AppendValues(const std::vector<value_type>& values) {
+ if (values.empty()) {
+ return Status::OK();
+ }
return AppendValues(values.data(), static_cast<int64_t>(values.size()));
return AppendValues(values.data(), static_cast<int64_t>(values.size()));
}
```
@pitrou @bkietz Should I just guard the vector interface? Or should prevent
from all AppendValues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
