tustvold commented on code in PR #6752:
URL: https://github.com/apache/arrow-rs/pull/6752#discussion_r1850611402
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -759,6 +763,12 @@ pub fn cast_with_options(
"Casting from type {from_type:?} to dictionary type
{to_type:?} not supported",
))),
},
+ (RunEndEncoded(re_t, _dt), _) => match re_t.data_type() {
Review Comment:
> I imagine copying Int16 data up to Int32 would have a pretty large
performance penalty in this case
I think we have to be pragmatic here, ultimately Int8 and Int16 are somewhat
useless, only able to support arrays of maximum length 128 and 32768
respectively. I'm honestly not entirely sure why they were standardised...
Another option might be to fallback to ArrayData for the Int8, Int16 and
Int64 cases. We really need to try to keep this change small
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
