devanbenz commented on code in PR #6757:
URL: https://github.com/apache/arrow-rs/pull/6757#discussion_r1851135486
##########
parquet/src/schema/types.rs:
##########
@@ -202,6 +202,33 @@ impl Type {
self.get_basic_info().has_repetition()
&& self.get_basic_info().repetition() != Repetition::REQUIRED
}
+
+ /// Returns `true` if this type is annotated as a list.
+ pub fn is_list(&self) -> bool {
+ match self.is_group() {
Review Comment:
Since `.is_group()` returns a boolean wouldn't it be better semantics to put
it inside a branch conditional just using `if`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
