pitrou commented on issue #12681: URL: https://github.com/apache/arrow/issues/12681#issuecomment-2490531049
Okay, so that might be because the compiled code uses FMADD which potentially removes one rounding step, yielding slightly different results. We can probably simply relax the test a tiny little bit. Given that this is gonna come up in other situations, we may add some helper functions: ```c++ bool WithinUlp(float left, float right, int n_ulps); bool WithinUlp(double left, double right, int n_ulps); void AssertWithinUlp(float left, float right, int n_ulps); void AssertWithinUlp(double left, double right, int n_ulps); ``` I can write those helpers if that sounds ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
