alamb commented on code in PR #6719:
URL: https://github.com/apache/arrow-rs/pull/6719#discussion_r1854558373
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -484,6 +484,13 @@ impl<T: ByteViewType + ?Sized, V: AsRef<T::Native>>
Extend<Option<V>>
/// ```
pub type StringViewBuilder = GenericByteViewBuilder<StringViewType>;
+impl std::fmt::Write for StringViewBuilder {
+ fn write_str(&mut self, s: &str) -> std::fmt::Result {
+ self.append_value(s);
Review Comment:
I was writing some tests for this, and it turns out this is different
behavior than `StringViewBuilder`
https://docs.rs/arrow/latest/arrow/array/builder/type.GenericStringBuilder.html#example-incrementally-writing-strings-with-stdfmtwrite
Specifically, calling `write_str` doesn't compete the row 🤔
I made a PR showing the problem: https://github.com/tlm365/arrow-rs/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
