alamb commented on PR #6777: URL: https://github.com/apache/arrow-rs/pull/6777#issuecomment-2495447988
> I think this will perform identically to just writing to a temporary `String` manually? Yes that is my understanding -- this API just attaches the temporary `String` to the builder if needed > I wonder if we could do something a bit more sophisticated, but then again perhaps it won't make a difference. I tried doing something more sophisticated (specifically building up the view incrementally, and writing to the buffer) but I gave up due to https://github.com/apache/arrow-rs/pull/6777#discussion_r1854768107 (which I forgot to submit yesterday) > > I like the Drop based flush, although it does introduce a bit of API inconsistency... Yeah, it is different than the StringBuilder API. I could add the same `formatter()` style API to the string builder too 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
