alamb commented on code in PR #6795:
URL: https://github.com/apache/arrow-rs/pull/6795#discussion_r1857302924
##########
parquet/examples/async_read_parquet.rs:
##########
@@ -45,7 +45,7 @@ async fn main() -> Result<()> {
builder = builder.with_projection(mask);
// Highlight: set `RowFilter`, it'll push down filter predicates to skip
IO and decode.
- // For more specific usage: please refer to
https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/src/physical_plan/file_format/parquet/row_filter.rs.
+ // For more specific usage: please refer to
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/src/physical_plan/file_format/parquet/row_filter.rs.
Review Comment:
```suggestion
// For more specific usage: please refer to
https://github.com/apache/datafusion/blob/main/datafusion/core/src/datasource/physical_plan/parquet/row_filter.rs.
```
##########
CONTRIBUTING.md:
##########
@@ -138,7 +138,7 @@ cargo test
cargo test -p arrow
```
-For some changes, you may want to run additional tests. You can find
up-to-date information on the current CI tests in
[.github/workflows](https://github.com/apache/arrow-rs/tree/master/.github/workflows).
Here are some examples of additional tests you may want to run:
+For some changes, you may want to run additional tests. You can find
up-to-date information on the current CI tests in
[.github/workflows](https://github.com/apache/arrow-rs/tree/main/.github/workflows).
Here are some examples of additional tests you may want to run:
Review Comment:
The old (`master`) urls still work too, but I think it is cleaner to simply
update them all
##########
README.md:
##########
@@ -19,8 +19,6 @@
# Native Rust implementation of Apache Arrow and Apache Parquet
-[](https://codecov.io/gh/apache/arrow-rs?branch=master)
Review Comment:
We don't run the coverage job anymore, so let's not feature an out of date
result prominently:
- https://github.com/apache/arrow-rs/pull/6602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
