tustvold commented on code in PR #6801:
URL: https://github.com/apache/arrow-rs/pull/6801#discussion_r1858029921
##########
object_store/src/aws/mod.rs:
##########
@@ -199,7 +199,25 @@ impl ObjectStore for AmazonS3 {
match put {
S3ConditionalPut::ETagPutIfNotExists =>
Err(Error::NotImplemented),
S3ConditionalPut::ETagMatch => {
- request.header(&IF_MATCH, etag.as_str()).do_put().await
+ match request
+ .header(&IF_MATCH, etag.as_str())
+ // Real S3 will occasionally report 409 Conflict
+ // if there are concurrent `If-Match` requests
+ // in flight, so we need to be prepared to retry
+ // 409 responses.
+ .retry_on_conflict(true)
+ .do_put()
+ .await
+ {
+ // Real S3 reports NotFound rather than
PreconditionFailed when the
+ // object doesn't exist. Convert to
PreconditionFailed for
+ // consistency with R2. This also matches what the
HTTP spec
Review Comment:
😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
