tustvold commented on code in PR #6779:
URL: https://github.com/apache/arrow-rs/pull/6779#discussion_r1858191994
##########
arrow-select/src/interleave.rs:
##########
@@ -231,6 +235,39 @@ fn interleave_dictionaries<K: ArrowDictionaryKeyType>(
Ok(Arc::new(array))
}
+fn interleave_views<T: ByteViewType>(
+ values: &[&dyn Array],
+ indices: &[(usize, usize)],
+) -> Result<ArrayRef, ArrowError> {
+ let interleaved = Interleave::<'_, GenericByteViewArray<T>>::new(values,
indices);
+ let mut views_builder = BufferBuilder::new(indices.len());
+ let mut buffers = Vec::with_capacity(values[0].len());
+
+ let mut buffer_lookup = HashMap::new();
Review Comment:
This misunderstands https://github.com/apache/arrow-rs/issues/6780, the
issue isn't not skipping buffers that aren't referenced, it is that the arrays
being interleaved may contain the same actual buffers, e.g. sourced from the
same parquet dictionary page. This needs to deduplicate based on the underlying
Buffer pointers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
