thinkharderdev commented on code in PR #6794:
URL: https://github.com/apache/arrow-rs/pull/6794#discussion_r1862288356
##########
object_store/src/multipart.rs:
##########
@@ -21,18 +21,36 @@
//! cloud storage services. It's designed to offer efficient, non-blocking
operations,
//! especially useful when dealing with large files or high-throughput systems.
-use async_trait::async_trait;
-
use crate::path::Path;
use crate::{MultipartId, PutPayload, PutResult, Result};
+use async_trait::async_trait;
-/// Represents a part of a file that has been successfully uploaded in a
multipart upload process.
+/// An etag of a part of a file that has been successfully uploaded in a
multipart upload process.
#[derive(Debug, Clone)]
pub struct PartId {
/// Id of this part
pub content_id: String,
}
+/// Represents a part of a file that has been successfully uploaded in a
multipart upload process.
+#[derive(Debug)]
+pub struct MultipartInfo {
+ /// Id of this part
+ pub e_tag: String,
+ /// Index of the part + 1
+ pub part_number: usize,
+ /// 256 bit SHA of the contents
+ pub checksum_sha256: Option<String>,
Review Comment:
Probably shouldn't assume this is a `sha256` checksum. Maybe just rename to
`checksum` and let it be opaque.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
