tustvold commented on issue #6727: URL: https://github.com/apache/arrow-rs/issues/6727#issuecomment-2506413074
The logic https://github.com/apache/arrow-rs/blob/main/arrow-select/src/take.rs#L235 is correct and should not be changed. Additionally https://github.com/apache/arrow-rs/blob/main/arrow-select/src/take.rs#L257 will perform the necessary validation to ensure the StructArray is valid. However, the case could be made that an error would be more helpful, and this should be relatively straighforward case of changing https://github.com/apache/arrow-rs/blob/main/arrow-select/src/take.rs#L257 to use [StructArray::try_new](https://docs.rs/arrow-array/latest/arrow_array/array/struct.StructArray.html#method.try_new) which will return an error instead of panicking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
