zeroshade commented on a change in pull request #9671:
URL: https://github.com/apache/arrow/pull/9671#discussion_r596233932
##########
File path: go/parquet/internal/bmi/_lib/bitmap_bmi2.s
##########
@@ -0,0 +1,174 @@
+ .text
Review comment:
Well, the assembly in the _lib directory technically doesn't have to
exist at build time / run time. It's only needed for generating the .s files in
the bmi directory itself via c2goasm. So you'd still have seamless `go get`
installation workflow and wouldn't need to regenerate the _lib .s files in
order to use this package.
That all being said, I'd rather keep all the files checked in anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
