Isaac7777-cpu-school commented on PR #44409: URL: https://github.com/apache/arrow/pull/44409#issuecomment-2507040754
> @deanm0000 @Isaac7777-cpu-school Sorry for the lack of response before, but I think this PR is misunderstanding that these functions are already tested on the C++ side. > > For example, the fact that `test_compute.py` does not test negative values is irrelevant, given that the C++ tests may already test such inputs, and the Python compute functions in `pyarrow.compute` are just wrappers around the respective C++ functionality. > > `test_compute.py` should therefore mostly exercise the wrapping logic. If there's really a need to improve the compute tests for more input values, it should therefore be done in the C++ side of Arrow, for example here for the decimal sum kernel: > > https://github.com/apache/arrow/blob/152e878a2e79877ec461f96cefc97663f0bc581f/cpp/src/arrow/compute/kernels/aggregate_test.cc#L496-L535 Hi, thank you for your reply. I guess I will close this PR for now and maybe work on improving the C++ side of testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
