tustvold commented on code in PR #6812:
URL: https://github.com/apache/arrow-rs/pull/6812#discussion_r1863408150
##########
arrow-data/src/transform/mod.rs:
##########
@@ -718,6 +720,28 @@ impl<'a> MutableArrayData<'a> {
self.data.len += len;
}
+ /// Extends the in progress array with the same value from the input arrays
+ ///
+ /// # Arguments
+ /// * `index` - the index of array that you what to copy values from
+ /// * `scalar_index` - the index of the scalar value to copy
+ /// * `count` - the number of times to repeat the value
+ ///
+ /// # Panic
+ /// This function panics if there is an invalid index,
+ /// i.e. `index` >= the number of source arrays
+ /// or `start` + `count` > the length of the `index`th array
+ ///
+ pub fn extend_scalar(&mut self, index: usize, scalar_index: usize, count:
usize) {
Review Comment:
```suggestion
pub fn extend_n(&mut self, index: usize, scalar_index: usize, count:
usize) {
```
Scalars don't really exist as a notion at this level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
