CrystalZhou0529 commented on code in PR #44822:
URL: https://github.com/apache/arrow/pull/44822#discussion_r1864659195
##########
cpp/src/arrow/compute/kernels/scalar_cast_string.cc:
##########
@@ -327,31 +329,43 @@ BinaryToBinaryCastExec(KernelContext* ctx, const
ExecSpan& batch, ExecResult* ou
}
}
- const int64_t sum_of_binary_view_sizes = util::SumOfBinaryViewSizes(
- input.GetValues<BinaryViewType::c_type>(1), input.length);
-
- // TODO(GH-43573): A more efficient implementation that copies the validity
- // bitmap all at once is possible, but would mean we don't delegate all the
- // building logic to the ArrayBuilder implementation for the output type.
- OutputBuilderType builder(options.to_type.GetSharedPtr(),
ctx->memory_pool());
- RETURN_NOT_OK(builder.Resize(input.length));
- RETURN_NOT_OK(builder.ReserveData(sum_of_binary_view_sizes));
- arrow::internal::ArraySpanInlineVisitor<I> visitor;
- RETURN_NOT_OK(visitor.VisitStatus(
- input,
- [&](std::string_view v) {
- // Append valid string view
- return builder.Append(v);
+ ArrayData* output = out->array_data().get();
+ output->length = input.length;
+ output->SetNullCount(input.null_count);
+
+ // Set up bitmap
+ if (input.offset == output->offset) {
+ output->buffers[0] = input.GetBuffer(0);
+ } else {
+ if (input.buffers[0].data != NULLPTR) {
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
