itsjunetime commented on PR #6742:
URL: https://github.com/apache/arrow-rs/pull/6742#issuecomment-2512039348
> I struggle to approve this as a number of these crates were being tested
with MSRV and were passing (e.g. arrow-flight)... Am I missing something?
Yes - everything was passing before, but it simply wasn't testing *every*
crate in this repo and we also had multiple MSRVs set *too* high (which msrv
testing wouldn't catch, since we don't try to verify that the MSRV is set as
low as it can go)
For example, `arrow-flight` was passing before, and we didn't change
anything about it - however, the `arrow-flight/gen` crate had the MSRV set too
low. It was set to 1.70.0, when the lowest version it actually supported was
1.71.1. We didn't catch this because the `arrow-flight` crate was already set
to 1.71.1, and that was the only thing we were testing.
In the same vein, the `arrow-integration-testing` and
`arrow-pyarrow-integration-testing` weren't being checked by CI at all either,
so their MSRVs had fallen out of sync. This probably won't impact dependents at
all, as I doubt anyone is using these crates besides this repo alone, but it's
just nice to have them more up-to-date with this change now.
Besides these sorts of things, the other main change is updating the
workspace's MSRV to 1.70 (from 1.62) since it had just fallen out-of-date with
what the minimum MSRV is within the workspace. Since the workspace MSRV is now
1.70, all the crates that previously had their MSRV explicitly set to
`"1.70.0"` can now just use `{ workspace = true }`.
This PR fixes the above issues by:
1. Using a `find` loop to test *every* Cargo.toml in the repo for CI,
instead of just a few hand-picked specific ones
2. Making sure at least one crate in the repo uses `rust-version = {
workspace = true }` so that the workspace's MSRV doesn't get out-of-date
anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
