alamb commented on code in PR #6781:
URL: https://github.com/apache/arrow-rs/pull/6781#discussion_r1868103770
##########
arrow-array/src/array/union_array.rs:
##########
@@ -1966,10 +1972,13 @@ mod tests {
let array = UnionArray::try_new(fields.clone(), type_ids, None,
children).unwrap();
- let result = array.logical_nulls();
+ let expected = BooleanBuffer::from(vec![false, false, true, false]);
- let expected = NullBuffer::from(vec![false, false, true, false]);
- assert_eq!(Some(expected), result);
+ assert_eq!(expected, array.logical_nulls().unwrap().into_inner());
+ assert_eq!(
+ expected,
+
array.mask_sparse_all_with_nulls_skip_one(array.fields_logical_nulls())
Review Comment:
What is this `mask_sparse_all_with_nulls_skip_one` function? This
formulation is somewhat confusing to me (without delving deeply into the code).
Is there any way to make this more "obvious" 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
