CurtHagenlocher commented on code in PR #2312:
URL: https://github.com/apache/arrow-adbc/pull/2312#discussion_r1868677213
##########
csharp/src/Client/AdbcCommand.cs:
##########
@@ -114,10 +115,31 @@ public override CommandType CommandType
}
}
+ /// <summary>
+ /// Gets or setts the name of the command timeout property for the
underlying ADBC driver.
Review Comment:
Also note that a particular driver may define this in a unit other than
seconds given the lack of a standard.
As a suggestion, if the property name were on the ADO.NET connection string,
it could be used much more transparently because the consumer will already have
to have a generic mechanism for setting connection string properties. With this
API, the consumer has to know explicitly that they're using a wrapped ADBC
driver in order to be able to use the `CommandTimeout` API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
