etseidl commented on code in PR #6828:
URL: https://github.com/apache/arrow-rs/pull/6828#discussion_r1869981364
##########
parquet/src/file/properties.rs:
##########
@@ -287,15 +287,22 @@ impl WriterProperties {
self.statistics_truncate_length
}
- /// Returns `coerce_types` boolean
+ /// Returns whether `coerce_types` is enabled (defaults to `false`).
///
/// Some Arrow types do not have a corresponding Parquet logical type.
/// Affected Arrow data types include `Date64`, `Timestamp` and `Interval`.
- /// Writers have the option to coerce these into native Parquet types. Type
- /// coercion allows for meaningful representations that do not require
- /// downstream readers to consider the embedded Arrow schema. However, type
+ /// Also, for [`List`] and [`Map`] types, Parquet expects certain schema
elements
Review Comment:
> Or set_coerce_types could link to here
I already made that change. My concern is that most of the deep
documentation is currently on the setters rather than the getters...this one is
an outlier.
Edit: I went ahead and moved the bulk of the documentation to the builder. I
think more eyes will find it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
