khwilson commented on PR #44630: URL: https://github.com/apache/arrow/pull/44630#issuecomment-2520878509
Thanks for the reviews. I can: * Fix up the Python docs; * Update the C++ docs for all the trig functions to reflect their domains instead of just "invalid inputs." * Sort the code as suggested. Remaining question for reviewers. In C++, `atanh(1) = + infinity` (and sets a divide by zero error). In Python `atanh(1)` is a domain error. Which behaviour should this library (which spans both C++ and Python) utilize? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
