birschick-bq commented on code in PR #2352:
URL: https://github.com/apache/arrow-adbc/pull/2352#discussion_r1872222495
##########
csharp/src/Client/AdbcCommand.cs:
##########
@@ -83,6 +85,12 @@ internal AdbcCommand(AdbcStatement adbcStatement,
AdbcConnection adbcConnection)
this.DbConnection = adbcConnection;
this.DecimalBehavior = adbcConnection.DecimalBehavior;
this.StructBehavior = adbcConnection.StructBehavior;
+
+ if (adbcConnection.CommandTimeoutValue != null)
+ {
+ this.AdbcCommandTimeoutProperty =
adbcConnection.CommandTimeoutValue.DriverPropertyName;
Review Comment:
Setting the value would avoid a duplicate key exception. I think it's okay
for this to take precedence over the the driver setting since the we're calling
from the DbConnection wrapper.
```suggestion
this.adbcConnectionParameters[connectionTimeoutValue.DriverPropertyName] =
connectionTimeoutValue.Value.ToString();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
