tv42 commented on issue #4840: URL: https://github.com/apache/arrow-rs/issues/4840#issuecomment-2522247612
I just lost an hour to this. The current API is miserable, and relying on users to notice the caveat about physical null in the docs **under the prefix "Note: For performance reasons"** will not work. You've documented correctness in a subsection about performance! Conflating what is stored with what it means is a huge logical error. https://ozlabs.org/~rusty/index.cgi/tech/2008-03-30.html (Also, https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html#method.is_null is also a miserable method name using a *third* definition of what "null" means.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
