nevi-me commented on a change in pull request #9612:
URL: https://github.com/apache/arrow/pull/9612#discussion_r597113266
##########
File path: rust/parquet/src/schema/types.rs
##########
@@ -479,13 +572,17 @@ impl<'a> GroupTypeBuilder<'a> {
/// Creates a new `GroupType` instance from the gathered attributes.
pub fn build(self) -> Result<Type> {
- let basic_info = BasicTypeInfo {
+ let mut basic_info = BasicTypeInfo {
name: String::from(self.name),
repetition: self.repetition,
converted_type: self.converted_type,
- logical_type: self.logical_type,
+ logical_type: self.logical_type.clone(),
id: self.id,
};
+ // Populate the converted type if only the logical type is populated
Review comment:
I added a test for the group type (modified an existing one), but for
primitive types, I need the schema printer + parser. So, I'll increase the test
coverage as part of #9705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
