tustvold commented on code in PR #6862:
URL: https://github.com/apache/arrow-rs/pull/6862#discussion_r1876452045
##########
parquet/src/column/writer/mod.rs:
##########
@@ -555,7 +555,12 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E>
{
/// of the current memory usage and not the final anticipated encoded size.
#[cfg(feature = "arrow")]
pub(crate) fn memory_size(&self) -> usize {
- self.column_metrics.total_bytes_written as usize +
self.encoder.estimated_memory_size()
+ self.data_pages
Review Comment:
Can we actually move this to get_estimated_total_byres below, it belongs
there more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
