kou commented on code in PR #44977:
URL: https://github.com/apache/arrow/pull/44977#discussion_r1876714036
##########
cpp/thirdparty/versions.txt:
##########
@@ -158,7 +158,7 @@ DEPENDENCIES=(
"ARROW_NLOHMANN_JSON_URL
nlohmann-json-${ARROW_NLOHMANN_JSON_BUILD_VERSION}.tar.gz
https://github.com/nlohmann/json/archive/refs/tags/${ARROW_NLOHMANN_JSON_BUILD_VERSION}.tar.gz";
"ARROW_OPENTELEMETRY_URL
opentelemetry-cpp-${ARROW_OPENTELEMETRY_BUILD_VERSION}.tar.gz
https://github.com/open-telemetry/opentelemetry-cpp/archive/refs/tags/${ARROW_OPENTELEMETRY_BUILD_VERSION}.tar.gz";
"ARROW_OPENTELEMETRY_PROTO_URL
opentelemetry-proto-${ARROW_OPENTELEMETRY_PROTO_BUILD_VERSION}.tar.gz
https://github.com/open-telemetry/opentelemetry-proto/archive/refs/tags/${ARROW_OPENTELEMETRY_PROTO_BUILD_VERSION}.tar.gz";
- "ARROW_ORC_URL orc-${ARROW_ORC_BUILD_VERSION}.tar.gz
https://archive.apache.org/dist/orc/orc-${ARROW_ORC_BUILD_VERSION}/orc-${ARROW_ORC_BUILD_VERSION}.tar.gz";
+ "ARROW_ORC_URL orc-${ARROW_ORC_BUILD_VERSION}.tar.gz
https://dlcdn.apache.org/orc/orc-${ARROW_ORC_BUILD_VERSION}/orc-${ARROW_ORC_BUILD_VERSION}.tar.gz";
Review Comment:
We must use `closer.lua` instead.
This link is unavailable for old releases.
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -738,9 +738,7 @@ if(DEFINED ENV{ARROW_ORC_URL})
set(ORC_SOURCE_URL "$ENV{ARROW_ORC_URL}")
else()
set_urls(ORC_SOURCE_URL
-
"https://www.apache.org/dyn/closer.cgi?action=download&filename=/orc/orc-${ARROW_ORC_BUILD_VERSION}/orc-${ARROW_ORC_BUILD_VERSION}.tar.gz";
Review Comment:
We must keep this and use this as the first candidate.
This redirects to downloads.apache.org , dlcdn.apache.org or something for
files that exist in https://dist.apache.org/repos/dist/release/orc/ ,
archive.apache.org otherwise.
BTW, it seems that `closer.cgi` is deprecated. We should use `closer.lua`
instead: https://infra.apache.org/release-download-pages.html#download-page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
