h-vetinari commented on issue #44982:
URL: https://github.com/apache/arrow/issues/44982#issuecomment-2532365767
Good news: the builds have passed the config stage on all platforms!
I left the patch removing `set(opentelemetry-cpp_SOURCE "AUTO")` for now,
that likely still worth doing.
I'll also need to double-check if a patch I had come with 1.5 years ago for
this (that still applies) is still relevant
```diff
diff --git a/cpp/src/arrow/util/tracing_internal.h
b/cpp/src/arrow/util/tracing_internal.h
index 6ed731599..79907cf0c 100644
--- a/cpp/src/arrow/util/tracing_internal.h
+++ b/cpp/src/arrow/util/tracing_internal.h
@@ -122,13 +122,13 @@ struct Scope {
opentelemetry::trace::Scope scope_impl;
};
-opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>& UnwrapSpan(
+ARROW_EXPORT opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>&
UnwrapSpan(
::arrow::util::tracing::SpanDetails* span);
-const opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>&
UnwrapSpan(
+ARROW_EXPORT const
opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>& UnwrapSpan(
const ::arrow::util::tracing::SpanDetails* span);
-opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>& RewrapSpan(
+ARROW_EXPORT opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>&
RewrapSpan(
::arrow::util::tracing::SpanDetails* span,
opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span> ot_span);
```
It likely is though, as shared builds on windows tend to fail if required
symbols aren't exported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
