kszucs commented on code in PR #45001:
URL: https://github.com/apache/arrow/pull/45001#discussion_r1880120996
##########
cpp/src/arrow/compute/light_array_internal.h:
##########
@@ -221,6 +226,17 @@ class ARROW_EXPORT KeyColumnArray {
ARROW_EXPORT Result<KeyColumnMetadata> ColumnMetadataFromDataType(
const std::shared_ptr<DataType>& type);
+ARROW_EXPORT Result<KeyColumnMetadata> ColumnMetadataFromDataType(const
DataType* type);
Review Comment:
This is not necessary anymore.
##########
cpp/src/arrow/compute/light_array_internal.h:
##########
@@ -221,6 +226,17 @@ class ARROW_EXPORT KeyColumnArray {
ARROW_EXPORT Result<KeyColumnMetadata> ColumnMetadataFromDataType(
const std::shared_ptr<DataType>& type);
+ARROW_EXPORT Result<KeyColumnMetadata> ColumnMetadataFromDataType(const
DataType* type);
+
+/// \brief Create KeyColumnArray instances from an ArraySpan (nested types
supported)
+///
+/// The caller should ensure this is only called on "key" columns. Some nested
types are
+/// supported up to 1 level of nesting (e.g. List<int8> but not
List<List<int8>>).
+/// \see ColumnMetadataFromDataType for details
+ARROW_EXPORT Result<KeyColumnArray> ColumnArrayFromArraySpan(const ArraySpan&
array_span,
Review Comment:
Delete this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
