EnricoMi commented on code in PR #44990:
URL: https://github.com/apache/arrow/pull/44990#discussion_r1883690432
##########
cpp/src/arrow/dataset/file_parquet_encryption_test.cc:
##########
@@ -51,8 +53,14 @@ using arrow::internal::checked_pointer_cast;
namespace arrow {
namespace dataset {
+// Tests come in these variations
+enum CompressionParam {
Review Comment:
you're right, fixed
##########
cpp/src/arrow/dataset/file_parquet_encryption_test.cc:
##########
@@ -90,7 +98,15 @@ class DatasetEncryptionTestBase : public ::testing::Test {
auto encryption_config =
std::make_shared<parquet::encryption::EncryptionConfiguration>(
std::string(kFooterKeyName));
- encryption_config->column_keys = kColumnKeyMapping;
+
+ if (GetParam() == COLUMN_KEY) {
+ encryption_config->column_keys = kColumnKeyMapping;
+ } else if (GetParam() == UNIFORM) {
+ encryption_config->uniform_encryption = true;
+ } else {
+ FAIL() << "Unsupported compression type " << GetParam();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
