wgtmac commented on code in PR #45016:
URL: https://github.com/apache/arrow/pull/45016#discussion_r1884010313
##########
cpp/src/parquet/properties.h:
##########
@@ -120,6 +123,12 @@ class PARQUET_EXPORT ReaderProperties {
page_checksum_verification_ = check_crc;
}
+ // Set the default read size to read the footer from a file. For high latency
+ // file systems and files with large metadata (>64KB) this can increase
performance
+ // by reducing the number of round-trips to retrieve the entire file
metadata.
+ size_t footer_read_size() const { return footer_read_size_; }
+ void set_footer_read_size(size_t size) { footer_read_size_ = size; }
Review Comment:
I agree that users are more interested in setter than getter. Therefore
adding a doc string for setter is useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
