zanmato1984 commented on code in PR #45008: URL: https://github.com/apache/arrow/pull/45008#discussion_r1886221709
########## cpp/src/arrow/stl.h: ########## @@ -187,6 +187,34 @@ struct ConversionTraits<std::vector<ValueCType>> } }; +template <class CType_, std::size_t N> Review Comment: The template parameter of `ConversionTraits` should be `ValueCType` instead of `CType_` (you are probably copying the style from `ARROW_STL_CONVERSION(CType_, ArrowType_)` but that is a macro parameter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
