etseidl commented on code in PR #6870:
URL: https://github.com/apache/arrow-rs/pull/6870#discussion_r1887318338
##########
parquet/src/column/writer/mod.rs:
##########
@@ -878,24 +878,67 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a,
E> {
}
}
+ /// Returns `true` if this column's logical type is a UTF-8 string.
+ fn is_utf8(&self) -> bool {
+ self.get_descriptor().logical_type() == Some(LogicalType::String)
+ || self.get_descriptor().converted_type() == ConvertedType::UTF8
+ }
Review Comment:
Yes, regardless of the encoding, the statistics are for the data itself. You
wouldn't see a dictionary key here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
