kou commented on issue #45032:
URL: https://github.com/apache/arrow/issues/45032#issuecomment-2547567398
Ah, sorry. This will fix the Linux error:
```diff
diff --git a/cpp/cmake_modules/FindzstdAlt.cmake
b/cpp/cmake_modules/FindzstdAlt.cmake
index 980cf26552..79da7089fd 100644
--- a/cpp/cmake_modules/FindzstdAlt.cmake
+++ b/cpp/cmake_modules/FindzstdAlt.cmake
@@ -130,13 +130,17 @@ if(zstdAlt_FOUND)
if(ARROW_ZSTD_USE_SHARED)
set(zstd_TARGET zstd::libzstd_shared)
add_library(${zstd_TARGET} SHARED IMPORTED)
+ if(WINDOWS)
+ set_target_properties(${zstd_TARGET} PROPERTIES IMPORTED_IMPLIB
"${ZSTD_LIB}")
+ else()
+ set_target_properties(${zstd_TARGET} PROPERTIES IMPORTED_LOCATION
"${ZSTD_LIB}")
+ endif()
else()
set(zstd_TARGET zstd::libzstd_static)
add_library(${zstd_TARGET} STATIC IMPORTED)
+ set_target_properties(${zstd_TARGET} PROPERTIES IMPORTED_LOCATION
"${ZSTD_LIB}")
endif()
- set_target_properties(${zstd_TARGET}
- PROPERTIES IMPORTED_LOCATION "${ZSTD_LIB}"
- INTERFACE_INCLUDE_DIRECTORIES
"${ZSTD_INCLUDE_DIR}")
+ target_include_directories(${zstd_TARGET} INTERFACE "${ZSTD_INCLUDE_DIR}")
message(STATUS "Zstandard library: ${ZSTD_LIB}")
message(STATUS "Zstandard include directory: ${ZSTD_INCLUDE_DIR}")
endif()
```
For Windows, is `/workspace/destdir/lib/libzstd.dll.a` really an imported
library? In general, `.dll.a` is an imported library with MinGW. Can we
download `/workspace/destdir/lib/libzstd.dll.a`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
